Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return IPNSRecords for ipns subdomain URLs #131

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Nov 5, 2024

Title

feat: return IPNSRecords for ipns subdomain URLs

Description

Adds the ability to get IPNS records given a fetch URL of http://k51_something.ipns.example.com

Fixes #29

Notes & open questions

My network gives issues when running tests, so I'm pushing this up hoping it will pass the tests on the CI.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@SgtPooki SgtPooki marked this pull request as ready for review November 7, 2024 18:58
@SgtPooki SgtPooki requested a review from a team as a code owner November 7, 2024 18:58
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

@SgtPooki SgtPooki merged commit 05b7ac6 into main Nov 13, 2024
24 checks passed
@SgtPooki SgtPooki deleted the 29-bug-handleipnsrecord-doesnt-support-httpipnsnameipnsdomain-urls branch November 13, 2024 23:00
github-actions bot pushed a commit that referenced this pull request Nov 13, 2024
## [@helia/verified-fetch-v2.1.0](https://github.com/ipfs/helia-verified-fetch/compare/@helia/verified-fetch-2.0.1...@helia/verified-fetch-2.1.0) (2024-11-13)

### Features

* return IPNSRecords for ipns subdomain URLs ([#131](#131)) ([05b7ac6](05b7ac6))
Copy link

🎉 This PR is included in version @helia/verified-fetch-v2.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: handleIPNSRecord doesn't support "http://<ipnsname>.ipns.<domain>" urls
1 participant